2_nd order unicycle #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akmaralAW
requested review from
whoenig
and removed request for
quimortiz and
whoenig
This reverts commit 9c3f059.
whoenig
approved these changes
Sep 1, 2023
|
I did quick look and seems fine. I think best test is just to merge this, update the submodules in dynoplan and dynobench and run the benchmark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unicycle_second_order implementation has been tested with swap1_unicycle_second and swap2_unicycle_second examples. Checker still reports jumps.
After merging it to joint_robot, I can merge changes in db-cbs.